[PWGLF] Add HI Lambda/AntiLambda polarization around jets workflow#15263
Merged
romainschotter merged 44 commits intoAliceO2Group:masterfrom Mar 4, 2026
Merged
[PWGLF] Add HI Lambda/AntiLambda polarization around jets workflow#15263romainschotter merged 44 commits intoAliceO2Group:masterfrom
romainschotter merged 44 commits intoAliceO2Group:masterfrom
Conversation
…eroanalysis.cxx code, locally
…ck table subscriptions, added QA histograms (event and V0 selection), derived data production, optimized duplicate parts on the Lambda vs AntiLambda hypothesis checks, added jet clustering.
…ion and some histograms are empty!)
…, adding N Jet constituents column. Renaming tables to keep the "s" convention.
…COMPLETE CODE, just bookkeeping!)
…gic. Will switch to a regular compile-time histogram naming, even though that adds a lot of repeated logic
… Added some missing fills to histograms
… macro to avoid rewriting 20*4 histogram fills by hand (now fixed at compile time). Still not works with current JetPolarizationIons definition (collIdx has trouble with Preslice, as it is a non-monotonic. Possibly O2 is mixing the TimeFrames and combining multiple GlobalIndices in a same subfolder of the derived data)
…o indexing error and physics is correct)
…xactly). Added Lambda rest frame polarization observables to compare with Hydro (still without event plane determination though!)
…r calculation, coarser binning in the LambdaMass axis for signal extraction
…ror propagation! Used TProfiles for convenience and correctness)
…. Adding QA calculations of ring observable with perpendicular jet direction and inverse polarization sign to test hypothesis of true signal
…g Armenteros Lambdas
cmuncinelli
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
maciacco,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692 and
smaff92
as code owners
Please consider the following formatting changes to AliceO2Group#15263
Please consider the following formatting changes to AliceO2Group#15263
romainschotter
approved these changes
Mar 4, 2026
vkucera
reviewed
Mar 6, 2026
| #ifndef PWGLF_DATAMODEL_LAMBDAJETPOL_H_ | ||
| #define PWGLF_DATAMODEL_LAMBDAJETPOL_H_ | ||
|
|
||
| #include <Framework/ASoA.h> |
Collaborator
There was a problem hiding this comment.
The header is broken because you don't include what you use. Please fix it.
vkucera
reviewed
Mar 6, 2026
Comment on lines
+29
to
+40
| // O2 Framework | ||
| #include <Framework/ASoA.h> | ||
| #include <Framework/ASoAHelpers.h> | ||
| #include <Framework/AnalysisDataModel.h> | ||
| #include <Framework/AnalysisTask.h> | ||
| #include <Framework/Logger.h> | ||
| #include <Framework/runDataProcessing.h> | ||
|
|
||
| // O2 CCDB / Conditions | ||
| #include "DataFormatsParameters/GRPMagField.h" | ||
| #include <CCDB/BasicCCDBManager.h> | ||
| #include <CCDB/CcdbApi.h> |
Collaborator
There was a problem hiding this comment.
You include plenty of unused headers in a wrong way and in a wrong order.
- Remove the comments.
- Include what you use: https://aliceo2group.github.io/analysis-framework/docs/tools/#cleaning-includes
- Fix the format.
Comment on lines
+39
to
+51
|
|
||
| // Custom data model: | ||
| #include "PWGLF/DataModel/lambdaJetPolarizationIons.h" | ||
|
|
||
| #include <cmath> | ||
| #include <map> | ||
| #include <string> | ||
| #include <vector> | ||
|
|
||
| // #include <TLorentzVector.h> | ||
| // #include <TVector3.h> | ||
| // New recommended format: | ||
| #include <Math/Vector3D.h> |
Collaborator
There was a problem hiding this comment.
Same comment about headers
| using namespace o2; | ||
| using namespace o2::framework; | ||
| using namespace o2::framework::expressions; | ||
| using std::array; |
| // Another version of this counter, which is already integrated in the Event Selection flow: | ||
| if (doEventQA && !validJetAlreadyFound) | ||
| fillEventSelectionQA(lastBinEvSel - 1, centrality); // hasRingJet passes | ||
| validJetAlreadyFound = true; |
| // Another version of this counter, which is already integrated in the Event Selection flow: | ||
| if (doEventQA && !validJetAlreadyFound) | ||
| fillEventSelectionQA(lastBinEvSel - 1, centrality); // hasRingJet passes | ||
| validJetAlreadyFound = true; |
vkucera
reviewed
Mar 6, 2026
| // cicero.domenico.muncinelli@cern.ch | ||
| // | ||
|
|
||
| #ifndef PWGLF_DATAMODEL_LAMBDAJETPOL_H_ |
Collaborator
There was a problem hiding this comment.
Wrong header guard, reported in CI.
vkucera
reviewed
Mar 6, 2026
Comment on lines
+73
to
+75
| DECLARE_SOA_COLUMN(V0CosPA, v0cosPA, float); | ||
| DECLARE_SOA_COLUMN(V0Radius, v0radius, float); | ||
| DECLARE_SOA_COLUMN(DcaV0Daughters, dcaV0daughters, float); |
Collaborator
There was a problem hiding this comment.
The capitalisations don't match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates the DataModel header, TableProducer, and derived data consumer for the Lambda/AntiLambda polarization analysis around jets in the HI (OO) context.
This workflow complements PWGLF's "lambdaJetPolarization.cxx" (pp) with HI-specific logic: jet background subtraction, centrality, etc.
New files: lambdaJetPolarizationIons.h, lambdaJetPolarizationIons.cxx, lambdaJetPolarizationIonsDerived.cxx.